[Nagiosplug-devel] check_dns broken in CVS

[Ton Voon]

On 8 Jan 2008, at 12:53, Matthias Eble wrote:

> Thomas Guyot-Sionnest schrieb:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Result of last commit to it...
>>
>> $ svn log check_dns.c|head
>> -  
>> ------------------------------------------------------------------------
>> r1886 | psychotrahe | 2008-01-04 20:06:36 -0500 (Fri, 04 Jan 2008)  
>> | 2 lines
>>
>> check_dns now sorts addresses for -a support with multiple address
>> replies (Matthias Urlichs #1724052)
>>
>> $ svn up -r1885 check_dns.c
>> U    check_dns.c
>> Updated to revision 1885.
>> $ make -q
>> $ ./check_dns -H 206.123.6.183 -a web.aei.ca. -t 5
>> DNS CRITICAL - '/usr/sbin/nslookup -sil' msg parsing exited with no  
>> address
>> $ svn up -rHEAD check_dns.c
>> U    check_dns.c
>> Updated to revision 1897.
>> $ make -q
>> $ ./check_dns -H 206.123.6.183 -a web.aei.ca. -t 5
>> DNS CRITICAL - '/usr/sbin/nslookup -sil' msg parsing exited with no  
>> address
>> $
>
> Hi Thomas,
>
> thank you.. jup there is/was a problem with the patch I applied. I  
> have
> overseen the reverse functionality and somehow interpreted the  
> testcase
> output as non-critical.. I'll commit a fix tonight.
>
> This shows again, how important software testing is.

Good work guys.

I just spotted this too. I was going to apply a patch to change the  
default DNS entries (was apple.com, but will switch to nagios.com  
instead) in the test script. Is this okay to do?

Ton

http://www.altinity.com
UK: +44 (0)870 787 9243
US: +1 866 879 9184
Fax: +44 (0)845 280 1725
Skype: tonvoon