[Nagiosplug-devel] Libtap included in distribution

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 26/06/08 06:01 PM, Ton Voon wrote:
> Hi!
> 
> Based on a comment made by Thomas, I've added the libtap distribution  
> into the nagios plugins project. This enables us to run C tests  
> without a dependency on external code.
> 
> It includes two changes to the libtap project from http://jc.ngo.org.uk/trac-bin/trac.cgi/wiki/LibTap 
>   including disabling LIBPTHREAD and asprintf from gnulib (http://jc.ngo.org.uk/trac-bin/trac.cgi/ticket/32 
> ).
> 
> libtap will only get included if ./configure --enable-libtap is set.  
> However, compiling will only take effect if a "make test" is run.
> 
> I'll see how the tinderbox builds cope tomorrow, but if all goes well,  
> I'll make this version of libtap available on our site.

Cool, Ton!

If I can find some free time I'll test it on my tinderbox and workstation.

We should also encourage tinderbox owners without libtap to use this
config option.

On a side note, looking at a recent bug report adding -D_FORTIFY_SOURCE
to CFLAGS adds a lot of checking and can help uncover bugs
(check_ntp_peer fails with this for instance - didn't have time to debug
yet).

I'm not sure if it's the correct way to enable these extra checks; if it
is we should add it to the devmode script (and more importantly remove
- -pedantic and some other annoying options).

Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIaBKC6dZ+Kt5BchYRAny8AKC4OHz1W4HnKg8ZsfoR/VcQZbrGbwCdGB9h
gMzi2vgUXQOIv39sFDbOUCg=
=FqIu
-----END PGP SIGNATURE-----