summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIustin Pop <iustin@debian.org>2019-01-18 21:52:54 (GMT)
committerJan Wagner <waja@cyconet.org>2019-01-18 21:52:54 (GMT)
commit8520c643dd35bbeebbf36c7145d3f8c12dfaf70b (patch)
treede4b21fa93415440ac031880febeacd197d04bd9
parent52373954332f517c4c52a8237dd20f5e91377128 (diff)
downloadmonitoring-plugins-8520c643dd35bbeebbf36c7145d3f8c12dfaf70b.tar.gz
Simply initializes n before it is usedrefs/pull/1574/head
When SSL is enabled, n is assigned the size of the server's second EHLO response (I think in bytes), which will usually be significantly higher than the command passed. As such, no commands are executed and no responses are checked, which - silently - defeats the desired checks and results in a success value.
-rw-r--r--plugins/check_smtp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/plugins/check_smtp.c b/plugins/check_smtp.c
index 0fcf4c6..d37c57c 100644
--- a/plugins/check_smtp.c
+++ b/plugins/check_smtp.c
@@ -293,6 +293,7 @@ main (int argc, char **argv)
293 printf("%s", buffer); 293 printf("%s", buffer);
294 } 294 }
295 295
296 n = 0;
296 while (n < ncommands) { 297 while (n < ncommands) {
297 xasprintf (&cmd_str, "%s%s", commands[n], "\r\n"); 298 xasprintf (&cmd_str, "%s%s", commands[n], "\r\n");
298 my_send(cmd_str, strlen(cmd_str)); 299 my_send(cmd_str, strlen(cmd_str));