check_snmp: refactoring + fixes

This commit moves the state retention logic to check_snmp as it is only
used there and I do not want it to be used at all, so it doesn't get a
place in the lib.

Otherwise this adapts tests and fixes the rate computing in the
refactored version of check_snmp.
Also fixes some bugs detected with the tests

4 files changed, 24 insertions, 534 deletions

diff --git a/lib/Makefile.am b/lib/Makefile.am
index a9f3ff40..27a08278 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -4,7 +4,7 @@ SUBDIRS = . tests
 
 noinst_LIBRARIES = libmonitoringplug.a
 
-AM_CPPFLAGS = -DNP_STATE_DIR_PREFIX=\"$(localstatedir)\" \
+AM_CPPFLAGS =  \
         -I$(srcdir) -I$(top_srcdir)/gl -I$(top_srcdir)/intl -I$(top_srcdir)/plugins
 
 libmonitoringplug_a_SOURCES = utils_base.c utils_tcp.c utils_cmd.c maxfd.c output.c perfdata.c output.c thresholds.c vendor/cJSON/cJSON.c
diff --git a/lib/tests/test_utils.c b/lib/tests/test_utils.c
index c3150f00..8040dec8 100644
--- a/lib/tests/test_utils.c
+++ b/lib/tests/test_utils.c
@@ -28,17 +28,7 @@
 #include "utils_base.c"
 
 int main(int argc, char **argv) {
-        char state_path[1024];
-        range *range;
-        double temp;
-        thresholds *thresholds = NULL;
-        int i, rc;
-        char *temp_string;
-        state_key *temp_state_key = NULL;
-        state_data *temp_state_data;
-        time_t current_time;
-
-        plan_tests(185);
+        plan_tests(155);
 
         ok(this_monitoring_plugin == NULL, "monitoring_plugin not initialised");
 
@@ -57,7 +47,7 @@ int main(int argc, char **argv) {
 
         np_set_args(argc, argv);
 
-        range = parse_range_string("6");
+        range *range = parse_range_string("6");
         ok(range != NULL, "'6' is valid range");
         ok(range->start == 0, "Start correct");
         ok(range->start_infinity == false, "Not using negative infinity");
@@ -97,7 +87,7 @@ int main(int argc, char **argv) {
         free(range);
 
         range = parse_range_string("12345678901234567890:");
-        temp = atof("12345678901234567890"); /* Can't just use this because number too large */
+        double temp = atof("12345678901234567890"); /* Can't just use this because number too large */
         ok(range != NULL, "'12345678901234567890:' is valid range");
         ok(range->start == temp, "Start correct");
         ok(range->start_infinity == false, "Not using negative infinity");
@@ -158,32 +148,34 @@ int main(int argc, char **argv) {
         range = parse_range_string("2:1");
         ok(range == NULL, "'2:1' rejected");
 
-        rc = _set_thresholds(&thresholds, NULL, NULL);
-        ok(rc == 0, "Thresholds (NULL, NULL) set");
+        thresholds *thresholds = NULL;
+        int returnCode;
+        returnCode = _set_thresholds(&thresholds, NULL, NULL);
+        ok(returnCode == 0, "Thresholds (NULL, NULL) set");
         ok(thresholds->warning == NULL, "Warning not set");
         ok(thresholds->critical == NULL, "Critical not set");
 
-        rc = _set_thresholds(&thresholds, NULL, "80");
-        ok(rc == 0, "Thresholds (NULL, '80') set");
+        returnCode = _set_thresholds(&thresholds, NULL, "80");
+        ok(returnCode == 0, "Thresholds (NULL, '80') set");
         ok(thresholds->warning == NULL, "Warning not set");
         ok(thresholds->critical->end == 80, "Critical set correctly");
 
-        rc = _set_thresholds(&thresholds, "5:33", NULL);
-        ok(rc == 0, "Thresholds ('5:33', NULL) set");
+        returnCode = _set_thresholds(&thresholds, "5:33", NULL);
+        ok(returnCode == 0, "Thresholds ('5:33', NULL) set");
         ok(thresholds->warning->start == 5, "Warning start set");
         ok(thresholds->warning->end == 33, "Warning end set");
         ok(thresholds->critical == NULL, "Critical not set");
 
-        rc = _set_thresholds(&thresholds, "30", "60");
-        ok(rc == 0, "Thresholds ('30', '60') set");
+        returnCode = _set_thresholds(&thresholds, "30", "60");
+        ok(returnCode == 0, "Thresholds ('30', '60') set");
         ok(thresholds->warning->end == 30, "Warning set correctly");
         ok(thresholds->critical->end == 60, "Critical set correctly");
         ok(get_status(15.3, thresholds) == STATE_OK, "15.3 - ok");
         ok(get_status(30.0001, thresholds) == STATE_WARNING, "30.0001 - warning");
         ok(get_status(69, thresholds) == STATE_CRITICAL, "69 - critical");
 
-        rc = _set_thresholds(&thresholds, "-10:-2", "-30:20");
-        ok(rc == 0, "Thresholds ('-30:20', '-10:-2') set");
+        returnCode = _set_thresholds(&thresholds, "-10:-2", "-30:20");
+        ok(returnCode == 0, "Thresholds ('-30:20', '-10:-2') set");
         ok(thresholds->warning->start == -10, "Warning start set correctly");
         ok(thresholds->warning->end == -2, "Warning end set correctly");
         ok(thresholds->critical->start == -30, "Critical start set correctly");
@@ -304,164 +296,28 @@ int main(int argc, char **argv) {
         test = np_extract_ntpvar("", "foo");
         ok(!test, "Empty string return NULL");
 
-        /* This is the result of running ./test_utils */
-        temp_string = (char *)_np_state_generate_key();
-        ok(!strcmp(temp_string, "e2d17f995fd4c020411b85e3e3d0ff7306d4147e"), "Got hash with exe and no parameters") ||
-                diag("You are probably running in wrong directory. Must run as ./test_utils");
-
-        this_monitoring_plugin->argc = 4;
-        this_monitoring_plugin->argv[0] = "./test_utils";
-        this_monitoring_plugin->argv[1] = "here";
-        this_monitoring_plugin->argv[2] = "--and";
-        this_monitoring_plugin->argv[3] = "now";
-        temp_string = (char *)_np_state_generate_key();
-        ok(!strcmp(temp_string, "bd72da9f78ff1419fad921ea5e43ce56508aef6c"), "Got based on expected argv");
-
-        unsetenv("MP_STATE_PATH");
-        temp_string = (char *)_np_state_calculate_location_prefix();
-        ok(!strcmp(temp_string, NP_STATE_DIR_PREFIX), "Got default directory");
-
-        setenv("MP_STATE_PATH", "", 1);
-        temp_string = (char *)_np_state_calculate_location_prefix();
-        ok(!strcmp(temp_string, NP_STATE_DIR_PREFIX), "Got default directory even with empty string");
-
-        setenv("MP_STATE_PATH", "/usr/local/nagios/var", 1);
-        temp_string = (char *)_np_state_calculate_location_prefix();
-        ok(!strcmp(temp_string, "/usr/local/nagios/var"), "Got default directory");
-
-        ok(temp_state_key == NULL, "temp_state_key initially empty");
-
-        this_monitoring_plugin->argc = 1;
-        this_monitoring_plugin->argv[0] = "./test_utils";
-        np_enable_state(NULL, 51);
-        temp_state_key = this_monitoring_plugin->state;
-        ok(!strcmp(temp_state_key->plugin_name, "check_test"), "Got plugin name");
-        ok(!strcmp(temp_state_key->name, "e2d17f995fd4c020411b85e3e3d0ff7306d4147e"), "Got generated filename");
-
-        np_enable_state("allowedchars_in_keyname", 77);
-        temp_state_key = this_monitoring_plugin->state;
-        sprintf(state_path, "/usr/local/nagios/var/%lu/check_test/allowedchars_in_keyname", (unsigned long)geteuid());
-        ok(!strcmp(temp_state_key->plugin_name, "check_test"), "Got plugin name");
-        ok(!strcmp(temp_state_key->name, "allowedchars_in_keyname"), "Got key name with valid chars");
-        ok(!strcmp(temp_state_key->_filename, state_path), "Got internal filename");
-
-        /* Don't do this test just yet. Will die */
-        /*
-        np_enable_state("bad^chars$in@here", 77);
-        temp_state_key = this_monitoring_plugin->state;
-        ok( !strcmp(temp_state_key->name, "bad_chars_in_here"), "Got key name with bad chars replaced" );
-        */
-
-        np_enable_state("funnykeyname", 54);
-        temp_state_key = this_monitoring_plugin->state;
-        sprintf(state_path, "/usr/local/nagios/var/%lu/check_test/funnykeyname", (unsigned long)geteuid());
-        ok(!strcmp(temp_state_key->plugin_name, "check_test"), "Got plugin name");
-        ok(!strcmp(temp_state_key->name, "funnykeyname"), "Got key name");
-
-        ok(!strcmp(temp_state_key->_filename, state_path), "Got internal filename");
-        ok(temp_state_key->data_version == 54, "Version set");
-
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Got no state data as file does not exist");
-
-        /*
-                temp_fp = fopen("var/statefile", "r");
-                if (temp_fp==NULL)
-                        printf("Error opening. errno=%d\n", errno);
-                printf("temp_fp=%s\n", temp_fp);
-                ok( _np_state_read_file(temp_fp) == true, "Can read state file" );
-                fclose(temp_fp);
-        */
-
-        temp_state_key->_filename = "var/statefile";
-        temp_state_data = np_state_read();
-        ok(this_monitoring_plugin->state->state_data != NULL, "Got state data now") ||
-                diag("Are you running in right directory? Will get coredump next if not");
-        ok(this_monitoring_plugin->state->state_data->time == 1234567890, "Got time");
-        ok(!strcmp((char *)this_monitoring_plugin->state->state_data->data, "String to read"), "Data as expected");
-
-        temp_state_key->data_version = 53;
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Older data version gives NULL");
-        temp_state_key->data_version = 54;
-
-        temp_state_key->_filename = "var/nonexistent";
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Missing file gives NULL");
-        ok(this_monitoring_plugin->state->state_data == NULL, "No state information");
-
-        temp_state_key->_filename = "var/oldformat";
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Old file format gives NULL");
-
-        temp_state_key->_filename = "var/baddate";
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Bad date gives NULL");
-
-        temp_state_key->_filename = "var/missingdataline";
-        temp_state_data = np_state_read();
-        ok(temp_state_data == NULL, "Missing data line gives NULL");
-
-        unlink("var/generated");
-        temp_state_key->_filename = "var/generated";
-        current_time = 1234567890;
-        np_state_write_string(current_time, "String to read");
-        ok(system("cmp var/generated var/statefile") == 0, "Generated file same as expected");
-
-        unlink("var/generated_directory/statefile");
-        unlink("var/generated_directory");
-        temp_state_key->_filename = "var/generated_directory/statefile";
-        current_time = 1234567890;
-        np_state_write_string(current_time, "String to read");
-        ok(system("cmp var/generated_directory/statefile var/statefile") == 0, "Have created directory");
-
-        /* This test to check cannot write to dir - can't automate yet */
-        /*
-        unlink("var/generated_bad_dir");
-        mkdir("var/generated_bad_dir", S_IRUSR);
-        np_state_write_string(current_time, "String to read");
-        */
-
-        temp_state_key->_filename = "var/generated";
-        time(&current_time);
-        np_state_write_string(0, "String to read");
-        temp_state_data = np_state_read();
-        /* Check time is set to current_time */
-        ok(system("cmp var/generated var/statefile > /dev/null") != 0, "Generated file should be different this time");
-        ok(this_monitoring_plugin->state->state_data->time - current_time <= 1, "Has time generated from current time");
-
-        /* Don't know how to automatically test this. Need to be able to redefine die and catch the error */
-        /*
-        temp_state_key->_filename="/dev/do/not/expect/to/be/able/to/write";
-        np_state_write_string(0, "Bad file");
-        */
-
-        np_cleanup();
-
-        ok(this_monitoring_plugin == NULL, "Free'd this_monitoring_plugin");
-
         ok(mp_suid() == false, "Test aren't suid");
 
         /* base states with random case */
         char *states[] = {"Ok", "wArnINg", "cRiTIcaL", "UnKNoWN", NULL};
 
-        for (i = 0; states[i] != NULL; i++) {
-                /* out of the random case states, create the lower and upper versions + numeric string one */
+        for (int i = 0; states[i] != NULL; i++) {
+                /* out of the random case states, create the lower and upper versions + numeric string one
+                 */
                 char *statelower = strdup(states[i]);
                 char *stateupper = strdup(states[i]);
                 char statenum[2];
-                char *temp_ptr;
-                for (temp_ptr = statelower; *temp_ptr; temp_ptr++) {
-                        *temp_ptr = tolower(*temp_ptr);
+                for (char *temp_ptr = statelower; *temp_ptr; temp_ptr++) {
+                        *temp_ptr = (char)tolower(*temp_ptr);
                 }
-                for (temp_ptr = stateupper; *temp_ptr; temp_ptr++) {
-                        *temp_ptr = toupper(*temp_ptr);
+                for (char *temp_ptr = stateupper; *temp_ptr; temp_ptr++) {
+                        *temp_ptr = (char)toupper(*temp_ptr);
                 }
                 snprintf(statenum, 2, "%i", i);
 
                 /* Base test names, we'll append the state string */
                 char testname[64] = "Translate state string: ";
-                int tlen = strlen(testname);
+                size_t tlen = strlen(testname);
 
                 strcpy(testname + tlen, states[i]);
                 ok(i == mp_translate_state(states[i]), testname);
diff --git a/lib/utils_base.c b/lib/utils_base.c
index 43e88e7a..29b393d0 100644
--- a/lib/utils_base.c
+++ b/lib/utils_base.c
@@ -74,14 +74,6 @@ void np_set_args(int argc, char **argv) {
 
 void np_cleanup(void) {
         if (this_monitoring_plugin != NULL) {
-                if (this_monitoring_plugin->state != NULL) {
-                        if (this_monitoring_plugin->state->state_data) {
-                                np_free(this_monitoring_plugin->state->state_data->data);
-                                np_free(this_monitoring_plugin->state->state_data);
-                        }
-                        np_free(this_monitoring_plugin->state->name);
-                        np_free(this_monitoring_plugin->state);
-                }
                 np_free(this_monitoring_plugin->plugin_name);
                 np_free(this_monitoring_plugin);
         }
@@ -435,339 +427,3 @@ int mp_translate_state(char *state_text) {
         }
         return ERROR;
 }
-
-/*
- * Returns a string to use as a keyname, based on an md5 hash of argv, thus
- * hopefully a unique key per service/plugin invocation. Use the extra-opts
- * parse of argv, so that uniqueness in parameters are reflected there.
- */
-char *_np_state_generate_key(void) {
-        char **argv = this_monitoring_plugin->argv;
-        unsigned char result[256];
-
-#ifdef USE_OPENSSL
-        /*
-         * This code path is chosen if openssl is available (which should be the most common
-         * scenario). Alternatively, the gnulib implementation/
-         *
-         */
-        EVP_MD_CTX *ctx = EVP_MD_CTX_new();
-
-        EVP_DigestInit(ctx, EVP_sha256());
-
-        for (int i = 0; i < this_monitoring_plugin->argc; i++) {
-                EVP_DigestUpdate(ctx, argv[i], strlen(argv[i]));
-        }
-
-        EVP_DigestFinal(ctx, result, NULL);
-#else
-
-        struct sha256_ctx ctx;
-
-        for (int i = 0; i < this_monitoring_plugin->argc; i++) {
-                sha256_process_bytes(argv[i], strlen(argv[i]), &ctx);
-        }
-
-        sha256_finish_ctx(&ctx, result);
-#endif // FOUNDOPENSSL
-
-        char keyname[41];
-        for (int i = 0; i < 20; ++i) {
-                sprintf(&keyname[2 * i], "%02x", result[i]);
-        }
-
-        keyname[40] = '\0';
-
-        char *keyname_copy = strdup(keyname);
-        if (keyname_copy == NULL) {
-                die(STATE_UNKNOWN, _("Cannot execute strdup: %s"), strerror(errno));
-        }
-
-        return keyname_copy;
-}
-
-void _cleanup_state_data(void) {
-        if (this_monitoring_plugin->state->state_data != NULL) {
-                np_free(this_monitoring_plugin->state->state_data->data);
-                np_free(this_monitoring_plugin->state->state_data);
-        }
-}
-
-/*
- * Internal function. Returns either:
- *   envvar NAGIOS_PLUGIN_STATE_DIRECTORY
- *   statically compiled shared state directory
- */
-char *_np_state_calculate_location_prefix(void) {
-        char *env_dir;
-
-        /* Do not allow passing MP_STATE_PATH in setuid plugins
-         * for security reasons */
-        if (!mp_suid()) {
-                env_dir = getenv("MP_STATE_PATH");
-                if (env_dir && env_dir[0] != '\0') {
-                        return env_dir;
-                }
-                /* This is the former ENV, for backward-compatibility */
-                env_dir = getenv("NAGIOS_PLUGIN_STATE_DIRECTORY");
-                if (env_dir && env_dir[0] != '\0') {
-                        return env_dir;
-                }
-        }
-
-        return NP_STATE_DIR_PREFIX;
-}
-
-/*
- * Initiatializer for state routines.
- * Sets variables. Generates filename. Returns np_state_key. die with
- * UNKNOWN if exception
- */
-void np_enable_state(char *keyname, int expected_data_version) {
-        if (this_monitoring_plugin == NULL) {
-                die(STATE_UNKNOWN, _("This requires np_init to be called"));
-        }
-
-        state_key *this_state = (state_key *)calloc(1, sizeof(state_key));
-        if (this_state == NULL) {
-                die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-        }
-
-        char *temp_keyname = NULL;
-        if (keyname == NULL) {
-                temp_keyname = _np_state_generate_key();
-        } else {
-                temp_keyname = strdup(keyname);
-                if (temp_keyname == NULL) {
-                        die(STATE_UNKNOWN, _("Cannot execute strdup: %s"), strerror(errno));
-                }
-        }
-
-        /* Die if invalid characters used for keyname */
-        char *tmp_char = temp_keyname;
-        while (*tmp_char != '\0') {
-                if (!(isalnum(*tmp_char) || *tmp_char == '_')) {
-                        die(STATE_UNKNOWN, _("Invalid character for keyname - only alphanumerics or '_'"));
-                }
-                tmp_char++;
-        }
-        this_state->name = temp_keyname;
-        this_state->plugin_name = this_monitoring_plugin->plugin_name;
-        this_state->data_version = expected_data_version;
-        this_state->state_data = NULL;
-
-        /* Calculate filename */
-        char *temp_filename = NULL;
-        int error =
-                asprintf(&temp_filename, "%s/%lu/%s/%s", _np_state_calculate_location_prefix(),
-                                 (unsigned long)geteuid(), this_monitoring_plugin->plugin_name, this_state->name);
-        if (error < 0) {
-                die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-        }
-
-        this_state->_filename = temp_filename;
-
-        this_monitoring_plugin->state = this_state;
-}
-
-/*
- * Will return NULL if no data is available (first run). If key currently
- * exists, read data. If state file format version is not expected, return
- * as if no data. Get state data version number and compares to expected.
- * If numerically lower, then return as no previous state. die with UNKNOWN
- * if exceptional error.
- */
-state_data *np_state_read(void) {
-        if (this_monitoring_plugin == NULL) {
-                die(STATE_UNKNOWN, _("This requires np_init to be called"));
-        }
-
-        bool error_code = false;
-
-        /* Open file. If this fails, no previous state found */
-        FILE *statefile = fopen(this_monitoring_plugin->state->_filename, "r");
-        if (statefile != NULL) {
-
-                state_data *this_state_data = (state_data *)calloc(1, sizeof(state_data));
-                if (this_state_data == NULL) {
-                        die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-                }
-
-                this_state_data->data = NULL;
-                this_monitoring_plugin->state->state_data = this_state_data;
-
-                error_code = _np_state_read_file(statefile);
-
-                fclose(statefile);
-        }
-
-        if (!error_code) {
-                _cleanup_state_data();
-        }
-
-        return this_monitoring_plugin->state->state_data;
-}
-
-/*
- * Read the state file
- */
-bool _np_state_read_file(FILE *state_file) {
-        time_t current_time;
-        time(&current_time);
-
-        /* Note: This introduces a limit of 1024 bytes in the string data */
-        char *line = (char *)calloc(1, 1024);
-        if (line == NULL) {
-                die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-        }
-
-        bool status = false;
-        enum {
-                STATE_FILE_VERSION,
-                STATE_DATA_VERSION,
-                STATE_DATA_TIME,
-                STATE_DATA_TEXT,
-                STATE_DATA_END
-        } expected = STATE_FILE_VERSION;
-
-        int failure = 0;
-        while (!failure && (fgets(line, 1024, state_file)) != NULL) {
-                size_t pos = strlen(line);
-                if (line[pos - 1] == '\n') {
-                        line[pos - 1] = '\0';
-                }
-
-                if (line[0] == '#') {
-                        continue;
-                }
-
-                switch (expected) {
-                case STATE_FILE_VERSION: {
-                        int i = atoi(line);
-                        if (i != NP_STATE_FORMAT_VERSION) {
-                                failure++;
-                        } else {
-                                expected = STATE_DATA_VERSION;
-                        }
-                } break;
-                case STATE_DATA_VERSION: {
-                        int i = atoi(line);
-                        if (i != this_monitoring_plugin->state->data_version) {
-                                failure++;
-                        } else {
-                                expected = STATE_DATA_TIME;
-                        }
-                } break;
-                case STATE_DATA_TIME: {
-                        /* If time > now, error */
-                        time_t data_time = strtoul(line, NULL, 10);
-                        if (data_time > current_time) {
-                                failure++;
-                        } else {
-                                this_monitoring_plugin->state->state_data->time = data_time;
-                                expected = STATE_DATA_TEXT;
-                        }
-                } break;
-                case STATE_DATA_TEXT:
-                        this_monitoring_plugin->state->state_data->data = strdup(line);
-                        if (this_monitoring_plugin->state->state_data->data == NULL) {
-                                die(STATE_UNKNOWN, _("Cannot execute strdup: %s"), strerror(errno));
-                        }
-                        expected = STATE_DATA_END;
-                        status = true;
-                        break;
-                case STATE_DATA_END:;
-                }
-        }
-
-        np_free(line);
-        return status;
-}
-
-/*
- * If time=NULL, use current time. Create state file, with state format
- * version, default text. Writes version, time, and data. Avoid locking
- * problems - use mv to write and then swap. Possible loss of state data if
- * two things writing to same key at same time.
- * Will die with UNKNOWN if errors
- */
-void np_state_write_string(time_t data_time, char *data_string) {
-        time_t current_time;
-        if (data_time == 0) {
-                time(&current_time);
-        } else {
-                current_time = data_time;
-        }
-
-        int result = 0;
-
-        /* If file doesn't currently exist, create directories */
-        if (access(this_monitoring_plugin->state->_filename, F_OK) != 0) {
-                char *directories = NULL;
-                result = asprintf(&directories, "%s", this_monitoring_plugin->state->_filename);
-                if (result < 0) {
-                        die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-                }
-
-                for (char *p = directories + 1; *p; p++) {
-                        if (*p == '/') {
-                                *p = '\0';
-                                if ((access(directories, F_OK) != 0) && (mkdir(directories, S_IRWXU) != 0)) {
-                                        /* Can't free this! Otherwise error message is wrong! */
-                                        /* np_free(directories); */
-                                        die(STATE_UNKNOWN, _("Cannot create directory: %s"), directories);
-                                }
-                                *p = '/';
-                        }
-                }
-                np_free(directories);
-        }
-
-        char *temp_file = NULL;
-        result = asprintf(&temp_file, "%s.XXXXXX", this_monitoring_plugin->state->_filename);
-        if (result < 0) {
-                die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), strerror(errno));
-        }
-
-        int temp_file_desc = 0;
-        if ((temp_file_desc = mkstemp(temp_file)) == -1) {
-                np_free(temp_file);
-                die(STATE_UNKNOWN, _("Cannot create temporary filename"));
-        }
-
-        FILE *temp_file_pointer = (FILE *)fdopen(temp_file_desc, "w");
-        if (temp_file_pointer == NULL) {
-                close(temp_file_desc);
-                unlink(temp_file);
-                np_free(temp_file);
-                die(STATE_UNKNOWN, _("Unable to open temporary state file"));
-        }
-
-        fprintf(temp_file_pointer, "# NP State file\n");
-        fprintf(temp_file_pointer, "%d\n", NP_STATE_FORMAT_VERSION);
-        fprintf(temp_file_pointer, "%d\n", this_monitoring_plugin->state->data_version);
-        fprintf(temp_file_pointer, "%lu\n", current_time);
-        fprintf(temp_file_pointer, "%s\n", data_string);
-
-        fchmod(temp_file_desc, S_IRUSR | S_IWUSR | S_IRGRP);
-
-        fflush(temp_file_pointer);
-
-        result = fclose(temp_file_pointer);
-
-        fsync(temp_file_desc);
-
-        if (result != 0) {
-                unlink(temp_file);
-                np_free(temp_file);
-                die(STATE_UNKNOWN, _("Error writing temp file"));
-        }
-
-        if (rename(temp_file, this_monitoring_plugin->state->_filename) != 0) {
-                unlink(temp_file);
-                np_free(temp_file);
-                die(STATE_UNKNOWN, _("Cannot rename state temp file"));
-        }
-
-        np_free(temp_file);
-}
diff --git a/lib/utils_base.h b/lib/utils_base.h
index 123066f8..f1c99a54 100644
--- a/lib/utils_base.h
+++ b/lib/utils_base.h
@@ -8,7 +8,6 @@
 #include "./perfdata.h"
 #include "./thresholds.h"
 
-
 #ifndef USE_OPENSSL
 #       include "sha256.h"
 #endif
@@ -26,25 +25,8 @@
 #define OUTSIDE 0
 #define INSIDE  1
 
-#define NP_STATE_FORMAT_VERSION 1
-
-typedef struct state_data_struct {
-        time_t time;
-        void *data;
-        int length; /* Of binary data */
-} state_data;
-
-typedef struct state_key_struct {
-        char *name;
-        char *plugin_name;
-        int data_version;
-        char *_filename;
-        state_data *state_data;
-} state_key;
-
 typedef struct np_struct {
         char *plugin_name;
-        state_key *state;
         int argc;
         char **argv;
 } monitoring_plugin;
@@ -100,10 +82,6 @@ char *np_extract_value(const char *, const char *, char);
  */
 int mp_translate_state(char *);
 
-void np_enable_state(char *, int);
-state_data *np_state_read(void);
-void np_state_write_string(time_t, char *);
-
 void np_init(char *, int argc, char **argv);
 void np_set_args(int argc, char **argv);
 void np_cleanup(void);