Fix off-by-one in news pagination page count

math.ceil() already rounds up when the post count isn't an exact
multiple of posts_per_page, so the extra "if remainder > 0" bump
double-counted and produced a page-count one higher than the number of
pages next_news_chunk() actually generates.  This made the news footer
link to a nonexistent last page (e.g., news/4.html when only 3 pages
exist).

1 files changed, 0 insertions, 2 deletions

diff --git a/web/macros.py b/web/macros.py
index e0e3feb..aee4917 100644
--- a/web/macros.py
+++ b/web/macros.py
@@ -82,8 +82,6 @@ def hook_preconvert_news():
     posts = [p for p in pages if 'date' in p]
     posts.sort(key=lambda p: p.date, reverse=True)
     n_news_pages = math.ceil(len(posts) / posts_per_page)
-    if len(posts) % posts_per_page > 0:
-        n_news_pages += 1
     for i, chunk in enumerate(next_news_chunk(posts, posts_per_page)):
         content = make_news_page(chunk, i) + make_news_footer(n_news_pages, i)
         if i == 0: